I left IIT Patna electrical and electronics for IIT Roorkee civil. Did I make the right decision?

Yes, you certainly made the right decision by choosing IIT Roorkee over IIT Patna. The biggest reason for saying this is that IIT Roorkee is an older IIT, thus having better opportunities, alumni, and experienced faculty. The career opportunities and exposure rendered by an old IIT cannot be compared to that of a new IIT. Irrespective of the branch you choose, old IITs will help you develop as a person. 

Additionally, the IIT Roorkee Civil Engineering branch is considered one of the best Civil branches in India. 

Many students prefer average branches like Mechanical and Civil at old IITs to top branches like CSE and EEE at new IITs. So go for IIT Roorkee without any second thoughts.